Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stage and ci jobs #224

Merged
merged 3 commits into from Aug 20, 2022
Merged

Test stage and ci jobs #224

merged 3 commits into from Aug 20, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 20, 2022

follow-up #209

Tests run on specific runners with respect to the target OS and the results are merged and sent to Codecov. Containerized tests are only available for host platform atm (that's why a specific job has been added in the build workflow).

cc @thaJeztah

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@0e5dbc6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #224   +/-   ##
=========================================
  Coverage          ?   51.13%           
=========================================
  Files             ?        9           
  Lines             ?      659           
  Branches          ?        0           
=========================================
  Hits              ?      337           
  Misses            ?      286           
  Partials          ?       36           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

```shell
# create builder
$ docker buildx create --use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a container builder? If it's just single arch, it should work without, I think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes required because we are building against multi-platforms (osxkeychain, wincred, pass)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, it's building all of them

what's the easiest way to build only one?

README.md Outdated Show resolved Hide resolved

The programs in this repository are written with the Go programming language. These instructions assume that you have previous knowledge about the language and you have it installed in your machine.
Or if the toolchain is already installed on your machine:

1 - Download the source and put it in your `$GOPATH` with `go get`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this section is in need of a rewrite as well (go get won't work anymore to clone the repository)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if we bump to Go 1.19 this has to be changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prepared #226 for go 1.18 (but best to do after this one)

@crazy-max crazy-max force-pushed the ci-test branch 2 times, most recently from ea3e129 to 1a03d8d Compare August 20, 2022 18:44
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit ab7fd12 into docker:master Aug 20, 2022
@crazy-max crazy-max deleted the ci-test branch August 20, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants