New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile for cross compilation #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good (thanks!) some questions
@@ -0,0 +1,82 @@ | |||
# syntax=docker/dockerfile:1 | |||
|
|||
ARG GO_VERSION=1.16.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(After this?) we should update to a current version of Go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just keeping minimal atm
FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
|
||
# osxcross contains the MacOSX cross toolchain for xx | ||
FROM crazymax/osxcross:${OSXCROSS_VERSION} AS osxcross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is built from https://github.com/crazy-max/osxcross ? Or from the upstream one? (I see neither repo tags releases, so was wondering what version it was built from)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is built from https://github.com/crazy-max/osxcross ?
It's built from https://github.com/crazy-max/docker-osxcross
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow-up #209 to split a bit what was done.
This one adds a Dockerfile to ease cross compilation and a simple GHA workflow that will just build the Dockerfile. Jenkinsfile has been removed as it's not used anymore. In another follow-up we can move the travis pipeline to GHA.
Build example: https://github.com/crazy-max/docker-credential-helpers/actions/runs/2288625907
cc @thaJeztah @ebriney