Allow pass helper to be built for macOS #169
Conversation
|
Please sign your commits following these rules: $ git clone -b "pass-macos-and-linux" git@github.com:ellsclytn/docker-credential-helpers.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
ellsclytn
force-pushed
the
pass-macos-and-linux
branch
from
1a0ee48
to
d6cbb0b
Compare
ellsclytn
force-pushed
the
pass-macos-and-linux
branch
from
d6cbb0b
to
d03999c
Compare
thaJeztah
force-pushed
the
pass-macos-and-linux
branch
from
d03999c
to
620dc60
Compare
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 9 9
Lines 666 666
=======================================
Hits 368 368
Misses 255 255
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Most of this PR was already merged as part of #187 - I did a quick rebase to see what's remaining in this PR 😅 |
|
Would need to also update Edit: @thaJeztah You beat me to it 😅 |
|
Yup, just realised, and just pushed before you commented 😂 |
Dockerfile
Outdated
| @@ -71,6 +71,9 @@ RUN --mount=type=bind,target=. \ | |||
| xx-go install std | |||
| xx-go build -ldflags "$(cat /tmp/.ldflags)" -o /out/docker-credential-osxkeychain-${TARGETARCH}${TARGETVARIANT} ./osxkeychain/cmd/main_darwin.go | |||
| xx-verify /out/docker-credential-osxkeychain-${TARGETARCH}${TARGETVARIANT} | |||
|
|
|||
| xx-go build -ldflags "$(cat /tmp/.ldflags)" -o /out/docker-credential-pass-${TARGETARCH}${TARGETVARIANT} ./pass/cmd/main.go | |||
| xx-verify /out/docker-credential-pass-${TARGETARCH}${TARGETVARIANT} | |||
There was a problem hiding this comment.
should add also ${TARGETOS} now that is not only linux.
There was a problem hiding this comment.
Ah, good one; wasn't sure if we collected them all in the same spot.
Let me have a look (we probably still need to look if we want to enable this by default and/or if that could mess up release pipelines elsewhere)
thaJeztah
force-pushed
the
pass-macos-and-linux
branch
from
6a7143b
to
2cf9be1
Compare
thaJeztah
force-pushed
the
pass-macos-and-linux
branch
2 times, most recently
from
c156609
to
68e116e
Compare
Pass is described as "The Standard Unix Password Manager", and so it can easily run on more than just Linux. Namely, it's supported on macOS. The CLI is identical to the Linux build, which means the Linux helper code for Pass is fully applicable toward the macOS build - a couple of renames being the only needed thing, purely for semantic correctness. Signed-off-by: Ellis Clayton <ellis@ellis.codes> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
pass-macos-and-linux
branch
from
68e116e
to
cc29c66
Compare
|
Rebased to get a fresh run of CI with the latest changes; still green, so let me get this one in 👍 |
Pass is described as "The Standard Unix Password Manager", and so it can
easily run on more than just Linux. Namely, it's supported on macOS. The
CLI is identical to the Linux build, which means the Linux helper code
for Pass is fully applicable toward the macOS build - a couple of
renames being the only needed thing, purely for semantic correctness.
Resolves #146