This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] Update changelog #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also include for known issues: |
jose-bigio
force-pushed
the
17.12_chng_log
branch
2 times, most recently
from
2b95d96
to
fd6f41d
Compare
|
Can we also add a mention of all the new aarch64 distros we added? Commit for reference: 8f588ee PR for reference as well: docker/docker-ce-packaging#35 |
seemethere
reviewed
Dec 21, 2017
CHANGELOG.md
Outdated
| @@ -12,6 +12,12 @@ See related PR: [moby/moby#35812](https://github.com/moby/moby/pull/35812) | |||
|
|
|||
| ## 17.12.0-ce (2017-12-DD) | |||
There was a problem hiding this comment.
TODO here: add a date when we pin down a GA date
jose-bigio
force-pushed
the
17.12_chng_log
branch
3 times, most recently
from
f5b6c31
to
3baffec
Compare
|
@gbarr01 PTAL |
mdlinville
suggested changes
Dec 26, 2017
|
|
||
| ## Known Issues | ||
| * AWS logs batch size calculation [moby/moby#35726](https://github.com/moby/moby/pull/35726) |
There was a problem hiding this comment.
Nit: newline after headings
There was a problem hiding this comment.
I can't seem to comment on this because it wasn't changed in this PR, but the admontion in line 8++ should be written as a real admonition:
> **Important**: <blah blah>
> More lines
{:.important}
Also s/should/must
jose-bigio
force-pushed
the
17.12_chng_log
branch
from
3baffec
to
e6bb2fd
Compare
seemethere
reviewed
Dec 27, 2017
CHANGELOG.md
Outdated
|
|
||
| You should stop all containers and plugins **BEFORE** upgrading to Docker CE 17.12. | ||
| You must stop all containers and plugins **BEFORE** upgrading to Docker CE 17.12. |
There was a problem hiding this comment.
Can you put this on the same line as the **IMPORTANT** line?
jose-bigio
force-pushed
the
17.12_chng_log
branch
from
e6bb2fd
to
a1e8238
Compare
seemethere
suggested changes
Dec 27, 2017
CHANGELOG.md
Outdated
| @@ -105,3 +108,4 @@ See related PR: [moby/moby#35812](https://github.com/moby/moby/pull/35812) | |||
| + Add Packaging for Fedora 27 [docker/docker-ce-packaging#59](https://github.com/docker/docker-ce-packaging/pull/59) | |||
| * Change default versioning scheme to 0.0.0-dev unless specified for packaging [docker/docker-ce-packaging#67](https://github.com/docker/docker-ce-packaging/pull/67) | |||
| * Pass Version to engine static builds [docker/docker-ce-packaging#70](https://github.com/docker/docker-ce-packaging/pull/70) | |||
| + Added support for aarch64 on Debian (stretch/jessie) and Ubuntu Xenial or newer [docker/docker-ce-packaging#35](https://github.com/docker/docker-ce-packaging/pull/35) | |||
There was a problem hiding this comment.
There was already aarch64 support for Ubuntu Xenial, this should be for Ubuntu Zesty instead.
Signed-off-by: jose-bigio <jose.bigio@docker.com>
jose-bigio
force-pushed
the
17.12_chng_log
branch
from
a1e8238
to
8673a42
Compare
seemethere
approved these changes
Dec 27, 2017
seemethere
referenced
this pull request
Dec 30, 2017
* add aarch64 support * use go 1.9 for arm64 support * fixtypo * add backports on jessie * fix path * delet yakkety * rm golang-go * use arm64v8/ images * fix error made in merge * remove double architecture * use arm64v8/ * use go 1.8.5 * Update aarch64 builds to 1.9.2 Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> Upstream-commit: 03eac42 Component: packaging
cpuguy83
pushed a commit
to cpuguy83/docker-ce
that referenced
this pull request
Feb 7, 2018
…ions Update __docker_get_log_options completion (zsh) Upstream-commit: 33a25708d4feb8e2402de491c952f2ffac603595 Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 7, 2019
Pin Golang images to debian stretch variant Upstream-commit: aab70be Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 20, 2019
[19.03] bump swarmkit to f35d9100f2c6ac810cc8d7de6e8f93dcc7a42d29 Upstream-commit: 2399b7a91b6a54c962f896e56a58b2d234d9366d Component: engine
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Pin Golang images to debian stretch variant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing change that didn't make it in to the release.
Signed-off-by: jose-bigio jose.bigio@docker.com