This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.12] awslogs: Use batching type for ergonomics and correct counting #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous bytes counter was moved out of scope was not counting the total number of bytes in the batch. This type encapsulates the counter and the batch for consideration and code ergonomics. Signed-off-by: Jacob Vallejo <jakeev@amazon.com> (cherry picked from commit ad14dbf) Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
|
Hi @anusha-ragunathan, thank you and team for this patch (and all the other great work you do)! We're eagerly awaiting it. Do you happen to know when 17.12.1 will be released? |
|
@alexthornton : I dont think 17.12.1 is scheduled at the moment. Typically patch releases are made when there're critical bug fixes needed. @andrewhsu or @thaJeztah will know more about a potential 17.12.1 release. |
|
@alexthornton it's already in Docker CE 18.01 (but that's on the "edge" channel, not "stable") |
|
Great! Thank you for the info. |
cpuguy83
pushed a commit
to cpuguy83/docker-ce
that referenced
this pull request
Feb 7, 2018
…e-volumes Add zsh completion for `system prune --volumes` Upstream-commit: 814827ef0ddc87850c7111ad1db4a41b30ebc588 Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 26, 2019
FIX pathing issue with cli dir Upstream-commit: 356c85b Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 20, 2019
…ma1-pull [19.03 backport] distribution: modify warning logic when pulling v2 schema1 manifests Upstream-commit: 421a3aa7375c33db33b5ea0e8aaa52a50aeaa8ed Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 27, 2020
[17.12] awslogs: Use batching type for ergonomics and correct counting
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.12] awslogs: Use batching type for ergonomics and correct counting
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
FIX pathing issue with cli dir
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git cherry-pick -s -x -Xsubtree=components/engine ad14dbf
Cherry-pick was clean.
Original PR moby/moby#35726
The previous bytes counter was moved out of scope was not counting the
total number of bytes in the batch. This type encapsulates the counter
and the batch for consideration and code ergonomics.
Signed-off-by: Jacob Vallejo jakeev@amazon.com
(cherry picked from commit ad14dbf)
Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com