This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.07] Fix error handling with not-exist errors on remove #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, none of the graphdrivers are supposed to return a not-exist type of error on remove (or at least that's how they are currently handled). Found that AUFS still had one case where a not-exist error could escape, when checking if the directory is mounted we call a `Statfs` on the path. This fixes AUFS to not return an error in this case, but also double-checks at the daemon level on layer remove that the error is not a `not-exist` type of error. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit d42dbdd) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
changed the title
tiborvass
pushed a commit
to tiborvass/docker-ce
that referenced
this pull request
Jul 31, 2017
Remove deprecated -e/--email flag from docker login Upstream-commit: a0066a150be45ede09fb9fa2ac92952e2d52fe19 Component: cli
|
ping @tiborvass @andrewhsu PTAL |
|
Test failures are consistent to what we know has been failing: Checked with: https://gist.github.com/seemethere/6128cb2391cd43b65b0ff4880af427e5 |
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 17, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: c2de74b Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Feb 21, 2019
…_on_rhel [18.09 backport] Skip kernel-memory tests on RHEL/CentOS daemons Upstream-commit: 6b0ba3745d073717887ead912c3c7dea4c99fc45 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.07] Fix error handling with not-exist errors on remove
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick moby/moby#33960