testing seccomp profile with kernel-version based rules #1015
+850
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 19, 2024
Comment on lines
+421
to
+441
| { | ||
| "names": [ | ||
| "fchmodat2", | ||
| "map_shadow_stack" | ||
| ], | ||
| "action": "SCMP_ACT_ALLOW", | ||
| "includes": { | ||
| "minKernel": "6.6" | ||
| } | ||
| }, | ||
| { | ||
| "names": [ | ||
| "futex_requeue", | ||
| "futex_wait", | ||
| "futex_wake" | ||
| ], | ||
| "action": "SCMP_ACT_ALLOW", | ||
| "includes": { | ||
| "minKernel": "6.7" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Trying if this would do the trick; conditionally add the new syscalls based on kernel version (not sure if it works though)
There was a problem hiding this comment.
OK, looks like this won't fix the issue. I was hoping that making these conditional would exclude them from the seccomp-profile, and make use of the stubs that runc creates, but that's not the case;
tar: engine/cli/winresources: Cannot change mode to rwxrwxr-x: Operation not permitted
tar: engine/cli: Cannot change mode to rwxrwxr-x: Operation not permitted
tar: engine/integration-cli/fixtures/https/client-key.pem: Cannot change mode to rwxrwxrwx: Operation not permitted
tar: engine/integration-cli/fixtures/https/client-cert.pem: Cannot change mode to rwxrwxrwx: Operation not permitted
tar: engine/integration-cli/fixtures/https/server-cert.pem: Cannot change mode to rwxrwxrwx: Operation not permitted
tar: engine/integration-cli/fixtures/https/server-key.pem: Cannot change mode to rwxrwxrwx: Operation not permitted
tar: engine/integration-cli/fixtures/https/ca.pem: Cannot change mode to rwxrwxrwx: Operation not permitted
tar: engine/integration-cli/fixtures/https: Cannot change mode to rwxrwxr-x: Operation not permitted
tar: engine/integration-cli/fixtures: Cannot change mode to rwxrwxr-x: Operation not permitted
tar: engine/integration-cli: Cannot change mode to rwxrwxr-x: Operation not permitted
tar: Exiting with failure status due to previous errors
make[1]: *** [Makefile:85: ubuntu-noble] Error 2
make[1]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-1015/deb'
make: *** [Makefile:83: ubuntu-noble] Error 2
script returned exit code 2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 19, 2024
Comment on lines
694
to
696
| "action": "SCMP_ACT_ERRNO", | ||
| "errnoRet": 38, | ||
| "errnoRet": 95, | ||
| "excludes": { |
There was a problem hiding this comment.
Yeah, this was a bit too naive of course; I thought "let's try change the default", but that means missing syscalls (not defined in the profile) will probably get ENOSYS as well;
pkg-buildpackage: info: source changed by Docker <support@docker.com>
dpkg-source -I.git --before-build .
dpkg-buildpackage: info: host architecture amd64
debian/rules clean
dh clean --with=bash-completion
make: dpkg-parsechangelog: Operation not permitted
make: dh: Operation not permitted
make: *** [debian/rules:121: clean] Error 127
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
make[1]: *** [Makefile:85: ubuntu-jammy] Error 2
make[1]: Leaving directory '/home/runner/work/docker-ce-packaging/docker-ce-packaging/deb'
make: *** [Makefile:83: ubuntu-jammy] Error 2
Error: Process completed with exit code 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)