add --no-consistency flag to convert command #9976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
glours
force-pushed
the
convert-consistency-flag
branch
2 times, most recently
from
ce9ea22
to
8effddb
Compare
Codecov ReportBase: 75.86% // Head: 75.86% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #9976 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 176 176
Misses 49 49
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
milas
reviewed
Nov 7, 2022
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
convert-consistency-flag
branch
from
8effddb
to
b51209c
Compare
ndeloof
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Add a
--no-consistencyflag toconfig/convertcommand which allows user to explicitly by pass the model consistency check. Usage of this flag may generate an invalid model regarding the Compose specification.Related issue
fixes #9963
depends on compose-spec/compose-go#318
(not mandatory) A picture of a cute animal, if possible in relation with what you did
