Strip up generic versions and bump requests #6778
Conversation
Replaces generic limitations with a next major value Bump the minimal `requests` to 2.20.0 Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
There was a problem hiding this comment.
Hi! This pull request looks well intended and looser boundaries will be of value in the context of non-system/pip context.
The added boundary to mock is a problem here though and makes things worse (see comment below) so please revert that part of the patch.
Also, the boundaries for PyYAML and texttable are not loose enough for today (see comments below).
| ] | ||
|
|
||
|
|
||
| if sys.version_info[:2] < (3, 4): | ||
| tests_require.append('mock >= 1.0.1') | ||
| tests_require.append('mock >= 1.0.1, < 2') |
There was a problem hiding this comment.
That would downgrade people with mock 2.0.0 and upstream is at 3.0.5 by now, so that change makes things worse.
There was a problem hiding this comment.
The idea here was just to use the current minimal boundaries to set the upper ones as it's a guaranty (as a safe move).
Then we should to bump every requirement independently (including requirements.txt so that the binary can evolve too).
There was a problem hiding this comment.
The idea here was just to use the current minimal boundaries to set the upper ones as it's a guaranty (as a safe move).
Original mock >= 1.0.1 pulled in 3.0.5 effectively so it should have been mock <4 not mock <2 to allow the same version as before.
Then we should to bump every requirement independently (including
requirements.txtso that the binary can evolve too).
That sounds right for texttable and pyyaml but not for mock.
Is there a guarantee that this branch is not ending up in a release? Is there a ticked or pull request about fixing the mock dependency regression now?
There was a problem hiding this comment.
Sure! I'll do the respective pull requests today 😃
| 'docopt >= 0.6.1, < 1', | ||
| 'PyYAML >= 3.10, < 5', | ||
| 'requests >= 2.20.0, < 3', | ||
| 'texttable >= 0.9.0, < 1', |
There was a problem hiding this comment.
That still forces users to downgrade from texttable 1.6.1 and from PyYAML 5.1.
|
Thank you |
Replaces generic limitations with a next major value
Bump the minimal
requeststo 2.20.0Resolves #6756