Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W.I.P.] Use yaml.safe_load rather than yaml.load #6744

Closed
wants to merge 1 commit into from

Conversation

hartwork
Copy link

@hartwork hartwork commented Jun 8, 2019

Mostly aiming at:

  • addressing security warning that tools might show
  • fixing the test suite for operating systems that path yaml.load to be disallowed

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "yaml-safe-load" git@github.com:hartwork/docker-compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@hartwork hartwork changed the title Use yaml.safe_load rather than yaml.load [W.I.P.] Use yaml.safe_load rather than yaml.load Jun 8, 2019
@hartwork
Copy link
Author

hartwork commented Jun 8, 2019

Closing as a duplicate, found #6623 just now

@hartwork hartwork closed this Jun 8, 2019
@hartwork hartwork deleted the yaml-safe-load branch June 8, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants