replace engine manual installation by crazy-max/ghaction-setup-docker #11763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Apr 24, 2024
glours
force-pushed
the
use-docker-crazymax-gha
branch
from
8e42007
to
c271384
Compare
|
Looking at ci failure you might also want to enforce |
glours
force-pushed
the
use-docker-crazymax-gha
branch
4 times, most recently
from
7dc8ad5
to
c8d4d32
Compare
crazy-max
reviewed
Apr 24, 2024
glours
force-pushed
the
use-docker-crazymax-gha
branch
from
c8d4d32
to
b4fd1f0
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
use-docker-crazymax-gha
branch
from
b4fd1f0
to
83bcc13
Compare
glours
requested review from
a team,
ndeloof,
milas and
jhrotko
and removed request for
a team
|
Fyi opened #11550 previously and got some issues with network related stuff. Guess we can close it if everything looks good here. |
|
@crazy-max We'll keep the original PR, I close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
CI is currently broken due to issue during Docker engine installation
I use @crazy-max GHA engine installer to fix the CI
edit: this isn't link to the last engine version installation process but a Microsoft issue in linux package repository
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
