Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip empty DNS entries to avoid Moby parse errors when creating sandbox DNS #11691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Strip empty DNS entries to avoid Moby parse errors when creating sandbox DNS #11691

wants to merge 1 commit into from

Conversation

IvanRibakov
Copy link

@IvanRibakov IvanRibakov commented Apr 5, 2024 •
edited

What I did

Ensured that each service's DNS settings are stripped from empty entries that could result from using ENV variables that defaulted to blank strings.

For example:

  service:
    # ANOTHER_SERVICE_IP is not set and defaults to blank string
    dns: ${ANOTHER_SERVICE_IP}
    ...

Related issue
#11690

@IvanRibakov IvanRibakov force-pushed the 11690-filter-empty-dns-entries branch from dc1eef6 to b6980b7 Compare April 8, 2024 06:23
@IvanRibakov IvanRibakov closed this Apr 8, 2024
@IvanRibakov IvanRibakov reopened this Apr 8, 2024
@IvanRibakov
Strip empty DNS entries to avoid parse errors when creating sandbox D…
0729508 
…NS in Moby

Signed-off-by: Ivan Ribakov <i.ribakov@zaleos.net>
@IvanRibakov IvanRibakov force-pushed the 11690-filter-empty-dns-entries branch from b6980b7 to 0729508 Compare April 8, 2024 14:24
@IvanRibakov
Copy link
Author

Is there anything I could do to help move this PR forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@IvanRibakov