Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt graph.InDependencyOrder #11256

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 7, 2023

What I did

example use for compose-spec/compose-go#506

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (bdbda79) 56.34% compared to head (0c93a2d) 55.38%.
Report is 11 commits behind head on main.

❗ Current head 0c93a2d differs from pull request most recent head 25db6a8. Consider uploading reports for the commit 25db6a8 to get more accurate results

Files Patch % Lines
pkg/compose/convert.go 52.38% 9 Missing and 1 partial ⚠️
cmd/compose/config.go 0.00% 4 Missing ⚠️
pkg/compose/create.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11256      +/-   ##
==========================================
- Coverage   56.34%   55.38%   -0.96%     
==========================================
  Files         134      133       -1     
  Lines       11560    11257     -303     
==========================================
- Hits         6513     6235     -278     
+ Misses       4407     4390      -17     
+ Partials      640      632       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant