Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework the creation of home & config directories created for e2e tests #11226

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glours
Copy link
Contributor

@glours glours commented Nov 27, 2023

What I did
Fixes the misconfiguration of home and config directories created by the e2e framework, also added the user config.json to avoid docker login message when pulling images (for users having Docker Desktop working with SSO)

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba24a65) 56.71% compared to head (e00adba) 56.88%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11226      +/-   ##
==========================================
+ Coverage   56.71%   56.88%   +0.16%     
==========================================
  Files         133      133              
  Lines       11497    11500       +3     
==========================================
+ Hits         6521     6542      +21     
+ Misses       4337     4323      -14     
+ Partials      639      635       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glours glours marked this pull request as draft November 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant