Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a fully containerized (via Compose) e2e setup #10980

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milas
Copy link
Member

@milas milas commented Sep 6, 2023

What I did
dind.compose.yaml has a Docker-in-Docker setup, which is then referenced via include in e2e.compose.yaml.

Not all tests currently pass, as some rely on bind mounts, for example.

(not mandatory) A picture of a cute animal, if possible in relation to what you did
falcon

`dind.compose.yaml` has a Docker-in-Docker setup, which is then
referenced via `include` in `e2e.compose.yaml`.

Not all tests currently pass, as some rely on bind mounts, for
example.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (aeb835a) 58.30% compared to head (9d13cba) 58.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10980      +/-   ##
==========================================
- Coverage   58.30%   58.28%   -0.02%     
==========================================
  Files         124      124              
  Lines       10912    10912              
==========================================
- Hits         6362     6360       -2     
- Misses       3922     3923       +1     
- Partials      628      629       +1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😊 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants