add buildx plugin to e2e configuration directory #10113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
nicksieger,
ndeloof,
StefanScherer,
milas and
laurazard
and removed request for
a team
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-buildx-plugin-e2e
branch
from
965d0a5
to
935968f
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
currently the version displayed is the one installed and not the one use for the tests Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-buildx-plugin-e2e
branch
from
518874e
to
183a092
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-buildx-plugin-e2e
branch
3 times, most recently
from
5763b92
to
be38d1a
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-buildx-plugin-e2e
branch
from
be38d1a
to
5dcadc0
Compare
Codecov ReportBase: 75.79% // Head: 73.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10113 +/- ##
==========================================
- Coverage 75.79% 73.01% -2.79%
==========================================
Files 2 2
Lines 252 289 +37
==========================================
+ Hits 191 211 +20
- Misses 53 65 +12
- Partials 8 13 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
We can't run locally e2e tests which need to configure buildx builder. I added a function to copy a specific CLI plugin to the e2e configuration directory and be sure the plugin will be available to run tests
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
