service hash MUST exclude replicas #10109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 76.98% // Head: 76.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10109 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 2 2
Lines 252 252
=======================================
Hits 194 194
Misses 51 51
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
nicksieger
approved these changes
Dec 20, 2022
ndeloof
force-pushed
the
hash
branch
2 times, most recently
from
34f985a
to
d18e0b6
Compare
laurazard
approved these changes
Dec 20, 2022
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix service hash computation to exclude deploy.replicas
Related issue
closes #10077
(not mandatory) A picture of a cute animal, if possible in relation to what you did
