update projectOptions to be public by renaming it to ProjectOptions
#10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Wang <tigerwang@outlook.com>
Codecov ReportBase: 76.98% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10103 +/- ##
==========================================
- Coverage 76.98% 75.79% -1.20%
==========================================
Files 2 2
Lines 252 252
==========================================
- Hits 194 191 -3
- Misses 51 53 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@ndeloof - how should I handle this code coverage issue? The change is literally turning lower cases to upper cases. Should I add unit tests for |
|
I also had strange results from codecov, seems this one is buggy :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Wang tigerwang@outlook.com
What I did
projectOptionsto be public by renaming it toProjectOptionstoProject(...)method ofprojectOptionsto be public by renaming it toToProject(...)Related issue
projectOptionscould be public so external code can use itstoProjectmethod to createtypes.Project#10102(not mandatory) A picture of a cute animal, if possible in relation to what you did
This is my cat - she never shows up and always hide herself somewhere in the house.