detect dependency failed to start #10101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
dependency_exit
branch
from
03f960c
to
1283c2f
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
glours
approved these changes
Dec 19, 2022
Codecov ReportBase: 76.98% // Head: 76.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10101 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 2 2
Lines 252 252
=======================================
Hits 194 194
Misses 51 51
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
dependency_exit
branch
from
1283c2f
to
cd67c86
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
dependency_exit
branch
from
cd67c86
to
5d0bef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
detect dependent service failed to start (container exited) and exit with error.
note: this doesn't cover scenarios like replicated service with one container to exit but the other eventually becoming healthy, container to restart after an initial failure, etc...
Related issue
closes #9732
(not mandatory) A picture of a cute animal, if possible in relation to what you did
