Use DOCKER_DEFAULT_PLATFORM to determine platform when creating container
#10099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
milas
and removed request for
a team
ndeloof
approved these changes
Dec 19, 2022
Codecov ReportBase: 77.02% // Head: 76.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10099 +/- ##
==========================================
- Coverage 77.02% 76.98% -0.04%
==========================================
Files 2 2
Lines 235 252 +17
==========================================
+ Hits 181 194 +13
- Misses 48 51 +3
- Partials 6 7 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
glours
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laura Brehm laurabrehm@hey.com
What I did
Previously we were only using
DOCKER_DEFAULT_PLATFORMto determine the default platform to use during pull. For consistency, we should apply the same logic when creating the container.Related issue
fixes #10041
(not mandatory) A picture of a cute animal, if possible in relation to what you did