fix regression 😓 running pull --ignore-pull-failures #10098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
ignore_pull_filures
branch
2 times, most recently
from
4a59a32
to
49f5a4d
Compare
ndeloof
changed the title
ndeloof
force-pushed
the
ignore_pull_filures
branch
from
49f5a4d
to
d7b59bb
Compare
Codecov ReportBase: 76.98% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10098 +/- ##
==========================================
- Coverage 76.98% 75.79% -1.20%
==========================================
Files 2 2
Lines 252 252
==========================================
- Hits 194 191 -3
- Misses 51 53 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
laurazard
approved these changes
Dec 19, 2022
ndeloof
force-pushed
the
ignore_pull_filures
branch
4 times, most recently
from
ba52f29
to
e1a2b57
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
ignore_pull_filures
branch
from
e1a2b57
to
c0a4a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
After #10054
--ignore-pull-failuresdoesn't ignore failures anymore 😓Fixed, added e2e tests to cover
pullandpull --ignore-pull-failuresfinal logic implemented by this flag:
--ignore-pull-failureis set, still report warning but exit with0Related issue
#10054
fixes #10089
(not mandatory) A picture of a cute animal, if possible in relation to what you did
