volume: fix WCOW volume mounts #10090
Conversation
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
Codecov ReportBase: 75.79% // Head: 76.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10090 +/- ##
==========================================
+ Coverage 75.79% 76.98% +1.19%
==========================================
Files 2 2
Lines 252 252
==========================================
+ Hits 191 194 +3
+ Misses 53 51 -2
+ Partials 8 7 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
milas
force-pushed
the
fix-wcow-volume
branch
from
f66007d
to
3dd4649
Compare
Do not use the older `Volumes` field in the API; instead rely on the more robust `Mounts`. For Linux containers, it seems that it's fine to set both of these. For Windows containers (WCOW), however, there appears to be a Moby bug that causes it to normalize the anonymous (`Volumes`) variant to lowercase, which can result in duplicative volume definitions and an error when trying to start the container. Fixes docker#9577. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
fix-wcow-volume
branch
from
3dd4649
to
ffb9544
Compare
|
/cc @neersighted - wondering if this is related to what you mentioned the other day (although in your case it didn't fail). (Wondering if we need to fix normalising (or duplicate detection at least) for Windows daemons) |
|
I'm wondering if you're talking about my issue with Desktop finding the wrong daemon/uninstalling the WCOW daemon during upgrade, or my issue with drvfs mounts disappearing using the WSL2 backend? It doesn't look like any of them to be, but maybe I'm thinking of the wrong thing? |
|
@neersighted oh! I misunderstood; thought you had issues with volumes 😂 |
What I did
Do not use the older
Volumesfield in the API; instead rely on the more robustMounts. For Linux containers, it seems that it's fine to set both of these. For Windows containers (WCOW), however, there appears to be a Moby bug that causes it to normalize the anonymous (Volumes) variant to lowercase, which can result in duplicative volume definitions and an error when trying to start the container.Related issue
Fixes #9577.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
