Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --timestamp option on compose up #10076

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 13, 2022

What I did
Add support for docker compose up --timestamp to align with same option on logs command.

Related issue
close #5730

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof force-pushed the timestamp branch 2 times, most recently from 798b11e to 33318e2 Compare December 13, 2022 18:16
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 76.98% // Head: 75.79% // Decreases project coverage by -1.19% ⚠️

Coverage data is based on head (84ea395) compared to base (1cb5536).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10076      +/-   ##
==========================================
- Coverage   76.98%   75.79%   -1.20%     
==========================================
  Files           2        2              
  Lines         252      252              
==========================================
- Hits          194      191       -3     
- Misses         51       53       +2     
- Partials        7        8       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 74.04% <0.00%> (-1.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is good - just the flag name 🙃

cmd/compose/up.go Outdated Show resolved Hide resolved
cmd/formatter/logs.go Outdated Show resolved Hide resolved
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 1b1f783 into docker:v2 Dec 15, 2022
@daevidvincent
Copy link

This is exciting! I've waited literally YEARS for this. What version of docker compose will this show up in?
I'm on Ubuntu and running v2.12.2 currently (from the https://docs.docker.com/compose/install/linux/ page method)

@ndeloof ndeloof deleted the timestamp branch December 16, 2022 07:47
@ndeloof
Copy link
Contributor Author

ndeloof commented Dec 16, 2022

@od-c0d3r
Copy link

@ndeloof, Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --timestamps option for "up" command
5 participants