Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of repository:tag #10072

Merged
merged 1 commit into from Dec 14, 2022
Merged

fix parsing of repository:tag #10072

merged 1 commit into from Dec 14, 2022

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 13, 2022

What I did
fix parsing of repository:tag

Related issue
close #9208

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof ndeloof force-pushed the repo_tag branch 2 times, most recently from edb10c0 to d8d386b Compare December 13, 2022 10:30
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 75.74% // Head: 77.02% // Increases project coverage by +1.27% 🎉

Coverage data is based on head (8df2d79) compared to base (3ee2ab8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10072      +/-   ##
==========================================
+ Coverage   75.74%   77.02%   +1.27%     
==========================================
  Files           2        2              
  Lines         235      235              
==========================================
+ Hits          178      181       +3     
+ Misses         50       48       -2     
+ Partials        7        6       -1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 75.22% <0.00%> (+1.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof force-pushed the repo_tag branch 2 times, most recently from 4f81631 to 17432e1 Compare December 13, 2022 10:41
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 05e987d into docker:v2 Dec 14, 2022
@ndeloof ndeloof deleted the repo_tag branch December 14, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

images command doesn't handle registry port numbers correctly in v2
3 participants