Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load project from files when explicitly set by user #10062

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 9, 2022

As a user run docker compose --file foo.yaml --project-name bar ..., parse the provided compose file as source of truth for the compose model the command will execute upon. Project should only be built from actual resources when there's no explicit compose file being set and we only rely on a project name.

Related issue
fixes #9554

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 76.98% // Head: 76.98% // No change to project coverage 👍

Coverage data is based on head (8498486) compared to base (1b1f783).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10062   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files           2        2           
  Lines         252      252           
=======================================
  Hits          194      194           
  Misses         51       51           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more predictable behavior-wise this way!

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose V2 stops all containers related to project
3 participants