Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go.* from e2e tests directory #10059

Merged
merged 1 commit into from Dec 8, 2022
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Dec 8, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Remove e2e test go.mod and go.sum

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours self-assigned this Dec 8, 2022
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested review from a team, nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team December 8, 2022 18:07
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 75.74% // Head: 75.74% // No change to project coverage 👍

Coverage data is based on head (cc247fd) compared to base (a4ac6ab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10059   +/-   ##
=======================================
  Coverage   75.74%   75.74%           
=======================================
  Files           2        2           
  Lines         235      235           
=======================================
  Hits          178      178           
  Misses         50       50           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My christmas wish is test/dev dependencies for go 🎅

@glours glours merged commit be74c90 into docker:v2 Dec 8, 2022
@glours glours deleted the remve-e2e-go.mod branch January 11, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants