port: improve error-handling if port not found #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
nicksieger
approved these changes
Dec 2, 2022
ndeloof
approved these changes
Dec 3, 2022
This method looked slightly incomplete. If the port wasn't found, it'd return `err`, but that was always `nil`, so we'd print out `:0`. Now, we construct a nice error message with the targeted port and the ones we found. The `--protocol` flag is also now case-insensitive to prevent any weirdness/confusion there. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Co-authored-by: Nick Sieger <nicksieger@gmail.com> Signed-off-by: Milas Bowman <milasb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This method looked slightly incomplete. If the port wasn't found, it'd return
err, but that was alwaysnil, so we'd print out:0.Now, we construct a nice error message with the targeted port and the ones we found.
The
--protocolflag is also now case-insensitive to prevent any weirdness/confusion there.Related issue
Fixes #10010.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
