introduce --parallel to limit concurrent engine calls #10030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
max_concurrency
branch
from
37b5d4b
to
cdabc00
Compare
glours
requested changes
Nov 30, 2022
ndeloof
force-pushed
the
max_concurrency
branch
2 times, most recently
from
51b5ee7
to
9bc188b
Compare
|
Oh nice! This is something that people have asked for for a while, albeit mostly regarding build operations. |
|
Build max-parallelism can be controlled, but this takes place on the builder side: https://github.com/docker/buildx/blob/master/docs/guides/resource-limiting.md#max-parallelism |
ndeloof
force-pushed
the
max_concurrency
branch
from
9bc188b
to
3078aee
Compare
ndeloof
force-pushed
the
max_concurrency
branch
from
3078aee
to
5bde50d
Compare
Codecov ReportBase: 77.02% // Head: 77.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10030 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 181 181
Misses 48 48
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
max_concurrency
branch
from
5bde50d
to
a0acc20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Introduce
--parallel=<int>for user to limit the concurrency during image pullscould be later applied to other operations, typically
buildwith adequate buildx|kit support for thisRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did
