fix deadlock waiting for attached-dependencies #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
10021
branch
2 times, most recently
from
eea1f22
to
d4b37dc
Compare
glours
reviewed
Nov 30, 2022
milas
approved these changes
Nov 30, 2022
glours
approved these changes
Nov 30, 2022
|
I canceled auto-merge - it looks like the E2E tests are legitimately hanging now and timing out after 15m |
ndeloof
force-pushed
the
10021
branch
2 times, most recently
from
ca70312
to
4f6ce85
Compare
|
still buggy, switching back to draft to prevent merge |
ndeloof
force-pushed
the
10021
branch
9 times, most recently
from
5051c1d
to
46568f4
Compare
ndeloof
force-pushed
the
10021
branch
5 times, most recently
from
0523eff
to
9fa1945
Compare
ndeloof
force-pushed
the
10021
branch
10 times, most recently
from
76c3208
to
0ed6ec0
Compare
Codecov ReportBase: 77.02% // Head: 75.74% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10029 +/- ##
==========================================
- Coverage 77.02% 75.74% -1.28%
==========================================
Files 2 2
Lines 235 235
==========================================
- Hits 181 178 -3
- Misses 48 50 +2
- Partials 6 7 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
explicit API to stop the log printer Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed 2 race conditions as we can configure
upto attach additional containers :Related issue
closes #10021
(not mandatory) A picture of a cute animal, if possible in relation to what you did
