move image digests resolution to backend #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
approved these changes
Nov 30, 2022
cmd/compose/convert.go
Outdated
| @@ -141,8 +141,9 @@ func runConvert(ctx context.Context, backend api.Service, opts convertOptions, s | |||
| } | |||
There was a problem hiding this comment.
oh yes indeed, my bad
ndeloof
force-pushed
the
cli_registry_client
branch
from
c43cb10
to
1f2f68f
Compare
|
Not sure if useful, but there's also |
|
@thaJeztah thanks, this is exactly what I was looking for! 🥰 |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
cli_registry_client
branch
from
e25e5be
to
8e57c6e
Compare
|
Make sure to double check in the cli as well as at some point resolution was moved; check for "no-resolve-image" (I think) on the docker cli (I'm just away from my keyboard right now 😬😅) |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
cli_registry_client
branch
from
8e57c6e
to
1540ddf
Compare
milas
approved these changes
Nov 30, 2022
| switch options.Format { | ||
| case "json": | ||
| return json.MarshalIndent(project, "", " ") | ||
| case "yaml": | ||
| return yaml.Marshal(project) | ||
| default: | ||
| return nil, fmt.Errorf("unsupported format %q", options) | ||
| return nil, fmt.Errorf("unsupported format %q", options.Format) |
There was a problem hiding this comment.
linter suddenly noticed this bug, while it existed before ... weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
introduced
ResolveImageDigestsin the API and moved image digest resolution to the backendlonger terms goal is to use
dockercli.RegistryClient()to replacecnab-to-ocidependency(not mandatory) A picture of a cute animal, if possible in relation with what you did
