useDockerDefaultOrServicePlatform fct should return service.platform if defined #10017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
…if defined and present in the build.platforms list (or if the list is empty) Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
use-service-platform-to-build-when-up
branch
from
a27f45f
to
0ee9afa
Compare
ndeloof
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and present in the build.platforms list (or if the list is empty)
Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com
What I did
Move the check of the
service.platformpresence inside theservice.build.platformslist with the test of the list size, to be sure we always return theservice.plaformvalue when present in the build platforms list or when this list is empty(not mandatory) A picture of a cute animal, if possible in relation with what you did
