Set pullChanged when setting --pull on compose up

Add e2e tests Signed-off-by: Laura Brehm <laurabrehm@hey.com>
docker · Dec 30, 2022 · a224780 · a224780
1 parent ffce33e
commit a224780
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cmd/compose/up.go b/cmd/compose/up.go
@@ -93,6 +93,7 @@ func upCommand(p *ProjectOptions, streams api.Streams, backend api.Service) *cob
 		Use:   "up [OPTIONS] [SERVICE...]",
 		Short: "Create and start containers",
 		PreRunE: AdaptCmd(func(ctx context.Context, cmd *cobra.Command, args []string) error {
+			create.pullChanged = cmd.Flags().Changed("pull")
 			create.timeChanged = cmd.Flags().Changed("timeout")
 			return validateFlags(&up, &create)
 		}),

diff --git a/e2e/cucumber-features/up.feature b/e2e/cucumber-features/up.feature
@@ -0,0 +1,15 @@
+Feature: Up
+
+Background:
+    Given a compose file
+        """
+        services:
+          simple:
+            image: alpine
+            command: top
+        """
+
+Scenario: --pull always
+    When I run "compose up --pull=always -d"
+    Then the output contains "simple Pulled"
+