bake/bin-image-cross: Add darwin #4996
Open
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4996 +/- ##
==========================================
- Coverage 61.04% 61.03% -0.01%
==========================================
Files 295 295
Lines 20648 20648
==========================================
- Hits 12605 12603 -2
- Misses 7147 7148 +1
- Partials 896 897 +1 |
sam-thibault
approved these changes
Apr 8, 2024
laurazard
approved these changes
Apr 10, 2024
Benehiko
approved these changes
Apr 10, 2024
vvoland
force-pushed
the
cli-bin-darwin
branch
2 times, most recently
from
a08a097
to
7e95682
Compare
Cross compiling CGO to Darwin requires an Apple SDK. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
So we can also have darwin binaries in the `dockereng/cli-bin` image. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can also have darwin binaries in the
dockereng/cli-binimage.Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com