Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document CLI support for per interface sysctls #4994

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Document CLI support for per interface sysctls #4994

wants to merge 6 commits into from
+122 −27

Commits on May 8, 2024

  1. Fix TestNetworkConnectWithFlags 

    The test didn't do anything useful...
- Despite its name it used newCreateCommand() instead of
  newConnectCommand() with create flags/options instead of connect.
- There was no fake networkCreateFunc(), so the result of the 'connect'
  wasn't checked.
- The fake networkConnectFunc() was never called, so didn't spot the
  problem.

Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e8bfedd View commit details
    Browse the repository at this point in the history

  2. Document the extended '--network' syntax 

    Support for connecting more than one network using the container run
command was added in v25.0 for API > 1.44 - describe that in the docs.

Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4758ed0 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Test quoted field in --network 

    Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 9, 2024
    Configuration menu
    Copy the full SHA
    abfdd70 View commit details
    Browse the repository at this point in the history

  2. Explain how to use "--network driver-opt" to set sysctls 

    Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ad39a3d View commit details
    Browse the repository at this point in the history

  3. Test quoted fields in --driver-opt 

    Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f66d4b4 View commit details
    Browse the repository at this point in the history

  4. Explain how to use "network connect --driver-opt" to set sysctls 

    Signed-off-by: Rob Murray <rob.murray@docker.com>
    @robmry
    robmry committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9f7d811 View commit details
    Browse the repository at this point in the history