Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: include required tools in source tree #4903

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

docs: include required tools in source tree #4903

wants to merge 1 commit into from
+22,666 −108

Commits on Apr 12, 2024

  1. docs: include required tools in source tree 

    In order to be able to build the documentation without internet access
(as is required by some distribution build systems), all of the source
code needed for the build needs to be available in the source tarball.

This used to be possible with the docker-cli sources but was
accidentally broken with some CI changes that switched to downloading
the tools (by modifying go.mod as part of the docs build script).

This pattern also maked documentation builds less reproducible since the
tool version used was not based on the source code version.

Fixes: commit 7dc35c0 ("validate manpages target")
Fixes: commit a650f4d ("switch to cli-docs-tool for yaml docs generation")
Co-authored-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @cyphar @thaJeztah
    cyphar and thaJeztah committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b46bfe4 View commit details
    Browse the repository at this point in the history