Basic devcontainer config #4845
Open
+81
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: krissetto <chrisjpetito@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 59.58% 61.28% +1.69%
==========================================
Files 288 287 -1
Lines 24821 20029 -4792
==========================================
- Hits 14790 12275 -2515
+ Misses 9145 6864 -2281
- Partials 886 890 +4 |
thaJeztah
reviewed
Feb 3, 2024
Comment on lines
+1
to
+3
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/go | ||
| { |
There was a problem hiding this comment.
JSON doesn't allow comments 🤔 should this have a jsonc file-extension ? (is that the official extension for it?)
There was a problem hiding this comment.
Unfortunately, the official devcontainers spec defines the file as a JSON with Comments, but using the .json extension. I know.
There was a problem hiding this comment.
😬 that feels very "YOLO - works for us, just not for everyone else"
Benehiko
reviewed
Feb 21, 2024
| * [Reporting Security Issues](#reporting-security-issues) | ||
| * [Design and Cleanup Proposals](#design-and-cleanup-proposals) | ||
| * [Reporting Issues](#reporting-other-issues) | ||
| * [Quick Contribution Tips and Guidelines](#quick-contribution-tips-and-guidelines) | ||
| * [Community Guidelines](#docker-community-guidelines) | ||
|
|
||
| ## Development environment |
There was a problem hiding this comment.
Another option is cloning the CLI repo inside your global GOPATH. Although I guess we will move to go modules soonish?
mkdir -p $GOPATH/src/github.com/docker/
cd $GOPATH/src/github.com/docker
git clone git@github.com:docker/cli.git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
devcontainerconfiguration to facilitate development on the codebase;README/CONTRIBUTINGdocs with some extra info on setting up a local development environment and using adevcontainer;- How to verify it
- Description for the changelog
Added initial devcontainer configuration
- A picture of a cute animal (not mandatory but encouraged)