Add CreatedAtTimestamp and fix CreatedAt docs #4765
+41
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon H <simon9ha@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 59.62% 59.62% -0.01%
==========================================
Files 287 285 -2
Lines 24777 24776 -1
==========================================
- Hits 14774 14772 -2
Misses 9117 9117
- Partials 886 887 +1 |
Benehiko
requested changes
Mar 11, 2024
| @@ -192,11 +192,16 @@ func (c *ContainerContext) Command() string { | |||
| return strconv.Quote(command) | |||
| } | |||
|
|
|||
| // CreatedAt returns the "Created" date/time of the container as a unix timestamp. | |||
| // CreatedAt returns the "Created" date/time of the container as a string | |||
There was a problem hiding this comment.
could we be more explicit as to which format the string would be in?
According to the docs this would be the format.
"2006-01-02 15:04:05.999999999 -0700 MST"
There's also a difference if c.c.Created contains nanoseconds.
withNanoseconds = 2000-02-01 12:13:14.000000015 +0000 UTC
withoutNanoseconds = 2000-02-01 12:13:14 +0000 UTC
Comment on lines
+200
to
+203
| // CreatedAtTimestamp returns the "Created" date/time of the container as a unix timestamp | ||
| func (c *ContainerContext) CreatedAtTimestamp() time.Time { | ||
| return time.Unix(c.c.Created, 0) | ||
| } |
There was a problem hiding this comment.
Not sure about this function here. It's not being used anywhere right now (except for tests). I would be in favor of just not adding this function since there is no use for it currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2413
- What I did
Added CreatedAtTimestamp and fix documentation for CreatedAt.
- How I did it
As above.
- How to verify it
TestContainerContextWriteJSON in container_test.go
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
