[23.0 backports] assorted backports #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes moby/moby#44904. Signed-off-by: Albin Kerouanton <albinker@gmail.com> (cherry picked from commit 56051b8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The error returned from "os/exec".Command when attempting to execute a directory has been changed from syscall.EACCESS to syscall.EISDIR on Go 1.20. golang/go@2b8f214 Consequently, any runc runtime built against Go 1.20 will return an error containing 'is a directory' and not 'permission denied'. Update the string matching so the CLI exits with status code 126 on 'is a directory' errors (EISDIR) in addition to 'permission denied' (EACCESS). Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit 9b5ceb5) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
no changes in vendored code full diff: containerd/containerd@v1.6.15...v1.6.16 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 5195db1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- client: improve error messaging on crash full diff: moby/moby@v23.0.0-rc.3...v23.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit bbebeba) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
Feb 6, 2023
cpuguy83
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)