Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set buildx as default builder #3314

Merged
merged 5 commits into from Feb 3, 2022
Merged

Set buildx as default builder #3314

merged 5 commits into from Feb 3, 2022

Commits on Feb 3, 2022

  1. Set buildx as default builder 

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    @crazy-max
    crazy-max committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    6fef143 View commit details
    Browse the repository at this point in the history

  2. builder: fallback to legacy 

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    @crazy-max
    crazy-max committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4d8e457 View commit details
    Browse the repository at this point in the history

  3. builder: simplify error generation, and rephrase error/warning 

    With this change:

    echo 'FROM busybox' | DOCKER_BUILDKIT=1 docker build -
    ERROR: BuildKit is enabled but the buildx component is missing or broken.
           Install the buildx component to build images with BuildKit:
           https://docs.docker.com/go/buildx/

    echo 'FROM busybox' | docker build -
    DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
                Install the buildx component to build images with BuildKit:
                https://docs.docker.com/go/buildx/

    Sending build context to Docker daemon  2.048kB
    ...

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah @crazy-max
    thaJeztah authored and crazy-max committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    bce65f0 View commit details
    Browse the repository at this point in the history

  4. Update deprecation docs 

    - expand a bit on what's happening
- clarify start of deprecation of the classic builder
- show examples of error and warning

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah @crazy-max
    thaJeztah authored and crazy-max committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    fd22746 View commit details
    Browse the repository at this point in the history

  5. builder: conditional warning for wcow 

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    @crazy-max
    crazy-max committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    16edf8b View commit details
    Browse the repository at this point in the history