Remove note about Git context not supporting subdir #3194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #3194 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 299 299
Lines 21501 21501
=======================================
Hits 12594 12594
Misses 7984 7984
Partials 923 923 |
tonistiigi
reviewed
Jul 19, 2021
| > **Note** | ||
| > | ||
| > You cannot specify the build-context directory (`myfolder` in the examples above) | ||
| > when using BuildKit as builder (`DOCKER_BUILDKIT=1`). Support for this feature |
There was a problem hiding this comment.
If this is specifically for DOCKER_BUILDKIT=1 then it has not been updated in dockerd release yet. We could add that it is supported since v0.9, currently supported via buildx.
|
LOL, looks like I had a draft PR for this as well #3125 |
|
@thaJeztah Sorry didn't see this one :D |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up moby/buildkit#2116, now fixed since BuildKit 0.9.0.
cc @thaJeztah
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com