Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainerFormat's CreatedAt has wrong documentation #2413

Open
diamondo25 opened this issue Apr 1, 2020 · 4 comments · May be fixed by #4765
Open

ContainerFormat's CreatedAt has wrong documentation #2413

diamondo25 opened this issue Apr 1, 2020 · 4 comments · May be fixed by #4765
Labels
exp/beginner help wanted kind/enhancement

Comments

@diamondo25
Copy link

cli/cli/command/formatter/container.go

Lines 179 to 182 in 389fa74

// CreatedAt returns the "Created" date/time of the container as a unix timestamp.
func (c *ContainerContext) CreatedAt() string {
return time.Unix(c.c.Created, 0).String()
}

time.Unix().String() will not create a unix timestamp (number), but instead will create an string as explained in the documentation: https://golang.org/pkg/time/#Time.String .

Maybe add another variant, eg CreatedAtTimestamp to support this option nonetheless.
@GOTAM672
Copy link

Hey, I'm a newcomer and I want to contribute to this project. Is this issue good to start?

@leungyukshing
Copy link

Hi, do we still work on this issue? I can help

@milanvthakor
Copy link

Hey, I have been working with GoLang for the past year and I would like to contribute to this project.

Open
@simonha9 simonha9 linked a pull request Jan 9, 2024 that will close this issue
Open
@simonha9
Copy link

simonha9 commented Jan 9, 2024

Hi, not sure if this is still being worked on but the change also needs a test update provided here: #4765

(Or feel free to update the original PR I'm easy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner help wanted kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CreatedAtTimestamp and fix CreatedAt docs simonha9/docker-cli
6 participants
@diamondo25 @thaJeztah @leungyukshing @simonha9 @GOTAM672 @milanvthakor