test: remove hardcoded files to check #39
Conversation
crazy-max
force-pushed
the
hardened-tests
branch
2 times, most recently
from
2272c56
to
cb09296
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 67.36% 69.58% +2.22%
==========================================
Files 4 4
Lines 576 434 -142
==========================================
- Hits 388 302 -86
+ Misses 132 76 -56
Partials 56 56 ☔ View full report in Codecov by Sentry. |
|
@thaJeztah PTAL |
clidocstool_test.go
Outdated
| bres, err := os.ReadFile(filepath.Join(tmpdir, tt)) | ||
| seen := make(map[string]struct{}) | ||
|
|
||
| require.NoError(t, filepath.Walk("fixtures", func(path string, info fs.FileInfo, err error) error { |
There was a problem hiding this comment.
Can we use filepath.WalkDir for these? Not sure if we need the added features of Walk 🤔
I'm wondering though if we're over-complicating things here; are we expecting to recurse here? Could we use a filepath.Glob(path/*.md) to get the list of markdown files? https://pkg.go.dev/path/filepath#Glob
There was a problem hiding this comment.
Can we use
filepath.WalkDirfor these? Not sure if we need the added features ofWalk🤔
I think it's fine to keep Walk even if it's always calling os.Lstat for these test cases. We have less than 10 files.
Could we use a
filepath.Glob(path/*.md)to get the list of markdown files? https://pkg.go.dev/path/filepath#Glob
No because we also need to check for dir existence which Walk provides efficiently.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
hardened-tests
branch
from
cb09296
to
04f2e85
Compare
Removes hardcoded files to verify in our tests but also check if unexpected files are generated and fail if not available in fixtures.