Add context-subdir input #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `context-subdir` input which gets appended to the context URL. This new input is ignored (with a warning) if the user gives a non-default `context` input such as a path. Signed-off-by: actualben <actualben@users.noreply.github.com>
BeyondEvil
reviewed
Dec 28, 2021
| @@ -97,7 +99,15 @@ export async function getArgs(inputs: Inputs, defaultContext: string, buildxVers | |||
| let args: Array<string> = ['buildx']; | |||
| args.push.apply(args, await getBuildArgs(inputs, defaultContext, buildxVersion)); | |||
| args.push.apply(args, await getCommonArgs(inputs, buildxVersion)); | |||
| args.push(inputs.context); | |||
| let context: string = inputs.context; | |||
| if (inputs.contextSubdir) { | |||
There was a problem hiding this comment.
Since the ability to add a subdirectory is only available in BuildX starting with v0.7.0, shouldn't you check that buildxVersion satisfies that? 🤔
|
closing in favor of #531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #531, that PR implements the magic var which you described in #460 (comment) .
This approach instead uses a new input
context-subdirwhich gets appended to the context URL. This new input is ignored (with a warning) if the user also specifies acontextinput such (as a path). The potential benefit to this approach is that it might be a little easier for users than utilizing a magic var.magic var:
vs
new input:
Closes #460
Closes #528