Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'quiet' docker arg support #486

Closed
wants to merge 8 commits into from
Closed

Added 'quiet' docker arg support #486

wants to merge 8 commits into from

Conversation

jj-mino
Copy link

@jj-mino jj-mino commented Oct 15, 2021

No description provided.

jj-mino and others added 7 commits October 15, 2021 12:34
Signed-off-by: Juan Miño <juan.mino@truenorth.co>
Signed-off-by: Juan Miño <juan.mino@truenorth.co>
Signed-off-by: Juan Miño <juan.mino@truenorth.co>
Copy link

@fearphage fearphage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try to maintain the current state of things.

@@ -210,6 +210,7 @@ Following inputs can be used as `step.with` keys
| `ssh` | List | List of SSH agent socket or keys to expose to the build |
| `tags` | List/CSV | List of tags |
| `target` | String | Sets the target stage to build |
| `quiet` | String | Suppress the build output and print image ID on success |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the previous options were in alphabetical order.

@@ -26,6 +26,7 @@ export interface Inputs {
noCache: boolean;
outputs: string[];
platforms: string[];
quiet: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize here too.

@@ -74,6 +75,7 @@ export async function getInputs(defaultContext: string): Promise<Inputs> {
load: core.getBooleanInput('load'),
network: core.getInput('network'),
noCache: core.getBooleanInput('no-cache'),
quiet: core.getBooleanInput('quiet'),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize here too.

@crazy-max
Copy link
Member

As discussed in #501, we are not going to add the quiet flag as it does not make much sense for the action itself.

@crazy-max crazy-max closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants