Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve quotes for set input fields #97

Merged
merged 2 commits into from Apr 17, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 19, 2022

follow-up docker/setup-buildx-action#175

There are cases where quotes need to be used for multi values fields like name for image type output:

set: |
  *.output=type=image,"name=moby/buildkit:v0.11.0,moby/buildkit:latest",push=true

Currently it would fail with: https://github.com/crazy-max/buildkit/actions/runs/3275927287/jobs/5391622084#step:7:122

  /usr/bin/docker buildx bake --set *.cache-from=type=gha,scope=cross --set *.cache-from=type=gha,scope=image --set *.cache-to=type=gha,scope=image --set *.output=type=image,name=***/buildkit:v0.11.0,***/buildkit:latest,buildinfo-attrs=true,push=true --set *.tags= --metadata-file /tmp/docker-build-push-1iSyRZ/metadata-file image-all --print
  ERROR: invalid value ***/buildkit:latest

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max force-pushed the fix-set-input branch 2 times, most recently from ae45b6a to f22eb39 Compare October 19, 2022 14:34
@crazy-max crazy-max force-pushed the fix-set-input branch 3 times, most recently from c14678c to 78ccefc Compare April 17, 2023 08:11
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jedevc April 17, 2023 08:51
@crazy-max crazy-max marked this pull request as ready for review April 17, 2023 08:52
@crazy-max crazy-max merged commit 39f20cb into docker:master Apr 17, 2023
20 checks passed
@crazy-max crazy-max deleted the fix-set-input branch April 17, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants