Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: write build summary #324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Apr 30, 2024

@crazy-max crazy-max force-pushed the build-summary branch 18 times, most recently from 44f8e01 to 3d602aa Compare May 7, 2024 12:26
@crazy-max crazy-max force-pushed the build-summary branch 3 times, most recently from 9363e4b to c989d9b Compare May 13, 2024 14:55
src/buildx/history.ts Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
.addRaw(`For a detailed look at the build, download the following <code>.dockerbuild</code> file and import it into Docker Desktop's Build views. `)
.addBreak()
.addRaw(`The build file provides insights of your build, such as timing, dependencies, results, logs, traces, and more. `)
.addRaw(addLink('Learn more', 'https://docs.docker.com/desktop/use-desktop/builds/#import-build-records'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn This anchor doesn't exist yet but it should instruct users of how to import builds in Docker Desktop. I will open an issue related to this shortly.

Copy link

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 copy nits from me

src/github.ts Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
@crazy-max crazy-max marked this pull request as ready for review May 14, 2024 11:36
@crazy-max crazy-max marked this pull request as draft May 14, 2024 11:42
@crazy-max crazy-max force-pushed the build-summary branch 2 times, most recently from b9e1301 to 450a6e0 Compare May 14, 2024 16:32
@crazy-max crazy-max marked this pull request as ready for review May 14, 2024 16:33
src/github.ts Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the build-summary branch 2 times, most recently from 9da7d1b to f32f7f9 Compare May 15, 2024 10:26
src/github.ts Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
.addRaw(`</p>`)
.addRaw(`<p>`)
.addRaw(`Find this useful? `)
.addRaw(addLink('Let us know', 'https://docs.docker.com/feedback/gha-build-summary'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redirect will be set in docker/docs#20043

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants