New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update stale bot to include only assigned #2806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine by me, we've been adding explicit stalebot-ignore
labels to ensure some are safe from the bot.
I have seen a PR (regarding LDAP docs) get closed by the bot, but to be fair I don't think the contributor was planning to ever get back to my feedback, even though the contribution was probably worthwhile to get through.
Some issues also get closed, and I'm a bit on the fence about it. I think we have a higher ratio of issues that are user specific and difficult to reproduce, or the user never responds back. The issue may not resolved, but if enough time has passed, then it may not get resolved and after enough time passes, we may have had enough changes that someone should report a similar experience as a new issue.
As such, while I do find the bot typically annoying, it is doing it's job at letting anyone know that is subscribed that it's been a while and the issue will be closed if there's no further engagement. We don't have that many contributors, anything long-lived assigned to a maintainer just gets the stalebot-ignore
label. I'm not sure if this setting will prove useful for this project.
Personal experience as a maintainer here would vote instead to increase the time until considered stale. That would seem more effective, 4 months seems appropriate?
I'm not against this change if others agree with it, so I'm approving. I don't see how it would be an improvement however (other than less notifications).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As such, while I do find the bot typically annoying, it is doing it's job at letting anyone know that is subscribed that it's been a while and the issue will be closed if there's no further engagement. We don't have that many contributors, anything long-lived assigned to a maintainer just gets the stalebot-ignore label
This 👍
But I don't have a strong opinion on that. So feel free to merge.
I'm more in favor of increasing the time it takes for the bot to kick an. As a maintainer, I am against this change, but I see that the majority has nothing against it. I will not stand in the way of merging this, but I cannot recommend it either: we still have plenty of issues (and PRs) that just rot, because no one is taking care. I rather see them closed so I can take care of activly maintained ones, then leave them open for a really long time. I do not have the solution, admittedly, but I do not think this change solves anything either, as stupid as that may sound. |
@georglauterbach and @casperklein are the most active maintainers currently, neither expressed a need for this change. The better change would be to raise the limit for when an issue / PR is considered stale (my suggestion was 4 months). If anyone is annoyed enough at the stale-bot, they should raise a PR to make that change. Closing ReasonAs cited above, this does not seem like it would be useful in the opinion of most maintainers. It may actually become a regression for the purpose it serves this project (an engagement prompt for anyone subscribed that cares). Thus rejecting until it can be shown the benefits are worthwhile for this project, compared to alternatives such as increasing the time requirement for the bot to trigger. |
Description
feature idea (i'm fine if this gets rejected as well):
include-only-assigned
issues for stale bot workflow.Instead of writing this myself i link to the comment that basically states my opinion: actions/stale#596 (comment)
Type of change
Checklist:
docs/
)