New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unwanted coercion in to_pydantic_model #949
Conversation
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
# Conflicts: # docarray/array/storage/milvus/seqlike.py
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Codecov ReportBase: 85.14% // Head: 85.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
+ Coverage 85.14% 85.21% +0.06%
==========================================
Files 155 155
Lines 8018 8048 +30
==========================================
+ Hits 6827 6858 +31
+ Misses 1191 1190 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test showing the behavior is correct?
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Goals:
This raises the required pydantic version to fix unwanted type coercion in
doc.to_pydantic_model()
, and by extension, indoc.to_dict()
.Before:
Note
tags={'title': 'inf'}
, it coerced"Infinity"
toinf
, not what we want.After:
Note
tags={'title': 'Infinity'}
, no unwanted coercion.