chore: move from flake8 to ruff for linting #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 14, 2022 10:37
Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai>
Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai>
Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai>
Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai>
Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai>
samsja
changed the title
dongxiang123
approved these changes
Nov 14, 2022
JohannesMessner
pushed a commit
that referenced
this pull request
Nov 16, 2022
* chore: add ruff and fix most of the errors Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> * chore: fix all of the rest of ruff problem Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> * chore: move from flake height to ruff in ci and pre commit Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> * chore: remove flake8 Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> * chore: remove line lenght ruff Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> Signed-off-by: Sami Jaghouar <sami.jaghouar@jina.ai> Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ruff is becoming industry standard and start replacing flake8 in modern python (example in fastAPI )
What this PR do