Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix DocList schema when using Pydantic V2 #1876

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: fix DocList schema when using Pydantic V2 #1876

wants to merge 10 commits into from

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 8, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 74.23%. Comparing base (f71a5e6) to head (d626453).

Files Patch % Lines
docarray/array/doc_list/doc_list.py 0.00% 9 Missing ⚠️
docarray/array/any_array.py 88.88% 1 Missing ⚠️
docarray/typing/bytes/base_bytes.py 0.00% 1 Missing ⚠️
docarray/typing/url/any_url.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1876       +/-   ##
===========================================
- Coverage   84.68%   74.23%   -10.45%     
===========================================
  Files         136      136               
  Lines        9261     9274       +13     
===========================================
- Hits         7843     6885      -958     
- Misses       1418     2389      +971
Flag Coverage Δ
docarray 74.23% <45.45%> (-10.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from 12cd670 to 1f35aca Compare March 11, 2024 10:34
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from e8c3334 to dfb3c85 Compare March 11, 2024 17:53
@JoanFM JoanFM linked an issue Mar 12, 2024 that may be closed by this pull request
Bug: Jsonschema of DocList not correct #1521
Open
@JoanFM JoanFM marked this pull request as ready for review March 12, 2024 15:25
@JoanFM JoanFM changed the title fix: try to fix doclist schema fix: Fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM JoanFM changed the title fix: Fix DocList schema when using Pydantic V2 fix: fix DocList schema when using Pydantic V2 Mar 12, 2024
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 3 times, most recently from b8e2b62 to ff2e56c Compare March 12, 2024 15:47
@github-actions github-actions bot added size/m and removed size/s labels Mar 12, 2024
@JoanFM JoanFM force-pushed the try-fix-doclist-schema branch 4 times, most recently from 118e751 to e2434fc Compare March 14, 2024 16:28
@github-actions GitHub Actions
Copy link

📝 Docs are deployed on https://ft-try-fix-doclist-schema--jina-docs.netlify.app 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/cicd area/core area/housekeeping area/testing area/typing component/array size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Jsonschema of DocList not correct
1 participant
@JoanFM